Go Back   Pligg CMS Forum > Pligg Development > Bug Report

Reply
 
LinkBack Thread Tools Display Modes
  #1 (permalink)  
Old 01-19-2006, 11:33 PM
New Pligger
 
Join Date: Jan 2006
Posts: 2
Thanks: 0
Thanked 0 Times in 0 Posts
Exclamation HUGE security concern - anybody can promote story instantly

I have found a HUGE security problem. ANY user can instantly promote a story to the homepage, regardless of the amount of "pliggs"...just like an admin can, by clicking the "Change the status" link. Here's the concern....ANYBODY can do this, whether they're an admin, or not....as long as they know the link to do it.

For example....

Somebody submits a story....the link to their story is as follows:

http://mypliggsite.com/story/16/

As long as they know the edit link for this (link that follows), they can edit it...even if they're not an admin. This is a huge problem.

http://mypliggsite.com/story/16/modify/main/

Had anyone else noticed this, or know how it can be fixed?
Reply With Quote
  #2 (permalink)  
Old 01-20-2006, 12:29 AM
AshDigg's Avatar
Coder
 
Join Date: Dec 2005
Posts: 1,574
Thanks: 235
Thanked 345 Times in 206 Posts
Thanks!

I usually check to make sure the user is "god" but in this case I didn't.

I'll get this fixed asap.

Thanks!
__________________
- Ash
Reply With Quote
  #3 (permalink)  
Old 01-20-2006, 09:06 PM
New Pligger
 
Join Date: Jan 2006
Posts: 18
Thanks: 0
Thanked 0 Times in 0 Posts
If you are impatient, this hack to linkadmin.php fixes the problem in a polite way.

Quote:
<?php
include('config.php');
include(mnminclude.'html1.php');
include(mnminclude.'link.php');

do_header('Link Admin', 'test');

force_authentication();
do_navbar('Link Admin');

if($current_user->user_level == "admin" or $current_user->user_level == "god") {; }
else
{
echo "<br />I am sorry, but you do not have administrative privileges on this site.<br />
If you wish to be promoted, please contact the site administrator.<br />";
return;
}
Reply With Quote
Reply

Thread Tools
Display Modes
Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Similar Threads
Thread Thread Starter Forum Replies Last Post
How to direct story title in summary page to the original story? chris79 General Help 4 02-03-2008 07:28 PM
Admin - Huge Security Vuln andiroo Bug Report 5 10-20-2006 08:12 PM
Idea for scalable story promotion jvallery Suggestions 6 04-18-2006 09:41 PM


Search Engine Friendly URLs by vBSEO 3.2.0