Top users problem

[lolmfao]

If you click a column heading to sort (I assume?) by that column it drops data.

http://ashtest1.pligg.com/topusers.php

Click news, published news, comments or published votes and you go from having 16 pages of users to 1.

Click total votes and there is 2 pages.

[Yankidank]

Um, I assume this isn't a problem. I think that people just sign up as users and don't vote or do anything else on the site. That would mean that the total users page gets 16 pages of results, but most other pages that take into account that the user must vote/comment and such there is only one page. It may look like an error, but it's actually a good thing because it's not listing anyone who is completely inactive.

[lolmfao]

If that is the case that it's just not listing the inactive ones, perhaps they should be seperated completely.

If it's not regular, consistent (not only with the site, but with what Joe Average is accustomed to) behaviour than it's a problem.

[AshDigg]

Yeah, thats a bug. You can see that some people have "1" in the "news" column. If you click news, you get only 1 page and it stops at "2" news and doesn't show any of the "1" people.

[gragland]

Any progress on this? I don't want users to be dropped from the table, even if they have a zero under the column that im sorting it by. What should I change in the code to make it so that doesn't happen?

[AshDigg]

I havn't dropped it, just been a wee bit sick. It on the bug tracker here

[AshDigg]

Partial fix...

/templates/skidoo_too/topusers_center.tpl

This should be the same line number for other templates (different folder of course), but I'm not certain.

Change line 21

from

$rows = $db->get_var("SELECT count(*) as count $from_where $order_by");

to

$rows = $db->query("SELECT * $from_where");


This doesn't show all users, just the users that have >0 in the column you've selected to sort by.