[SOLVED] Query fix (speed up)

[peppolone]

i saw there was always one query in my db

SELECT link_id, count( link_id ) AS count FROM pligg_links, pligg_categories WHERE category_lang = 'en' AND category_id = link_category GROUP BY link_category ORDER BY category_name ASC ;

it takes about 1 second and resides in the file /libs/html1.php
i removed the line

$sql = "select *,  count(*) as count from " . table_links . ", " . table_categories . " where category_lang='$dblang' and category_id=link_category group by link_category ORDER BY category_name ASC";

and now my site is very fast, this is the best fix i found.
i know it is for categorylist, but all in my sidebar works fine, i think it is an old query, i found it only in pligg 8.0 into categories.tpl
{section name=nr loop=$categorylist}
now we have loop=$cat_array
sry for my english

[xiesi]

yes!!Affter i removed is very fast.thanks

[TypeEE]

Did you remove all the 3 lines?

PHP Code:

$sql = "select *,  count(*) as count from " . table_links . ", " . table_categories . " where category_lang='$dblang' and category_id=link_category group by link_category ORDER BY category_name ASC";
$categorylist = object_2_array($db->get_results($sql));
$var_smarty->assign('categorylist', $categorylist); 


[peppolone]

Originally Posted by TypeEE

Did you remove all the 3 lines?

PHP Code:

$sql = "select *,  count(*) as count from " . table_links . ", " . table_categories . " where category_lang='$dblang' and category_id=link_category group by link_category ORDER BY category_name ASC";
$categorylist = object_2_array($db->get_results($sql));
$var_smarty->assign('categorylist', $categorylist); 


yes remove all categorylist.
thank me on the first post if you like my fix.

[TypeEE]

Thank you!!!

[Yankidank]

Added to Pligg SVN.

[peppolone]

when can i find my name into the code lol

[rubber2002]

thanks. After I remove the code you suggested, my site is fast.

[ArturOzimek]

My site is much faster as well. well done.thanks

[neo2cold]

Thanks so much for this , this really helps