A lot of comment forms

[SPICE]

Hi,
I noticed that there are a lot of comment forms (or reply forms) on the storypage. It's because we have each new form for each "reply" link. I think, it's not good for slow-connected users. First solution is to delete reply form and a link (better for me, eh :) ), another solution is to use javascript/AJAX (copy already existing form in another container), or simply use an hidden input for mainform and copy there parent id when the user hit reply link.

[Daniel]

Forget troubleshooting Spice, I think we should gzip files with the following simple php method and they should load like a rocket!

All you have to do is put the following line at the VERY top of each PHP document, and just like magic, the entire HTML of the page will be compressed!

<? ob_start("ob_gzhandler"); ?>

Read more here http://www.pligg.com/forum/showpost....1&postcount=20

[kbeeveer46]

Daniel, this has already been implemented in Pligg. It didn't have that much of an effect but after using a program called 7-zip i was able to compress all the files manually and then add them to Pligg. This is where a lot of the savings came from.

[Daniel]

Originally Posted by kbeeveer46

Daniel, this has already been implemented in Pligg. It didn't have that much of an effect but after using a program called 7-zip i was able to compress all the files manually and then add them to Pligg. This is where a lot of the savings came from.

It doesn't seem to be implemented. I just randomly checked this file admin_index.php. This line of code was not added:

<? ob_start("ob_gzhandler"); ?>

According to the link you provided earlier, that line of the code should be added to all php files.

Now, you said you gzipped only .js files and achieved remarkable results, right? Have you gzipped anything else? Could it be that simple? I might gzipped them tonight and then run a clean install.

[kbeeveer46]

there are 2 files in the SVN called begin_gzip.php and end_gzip.php. You have to enable them via the code at the top of .htaccess.

I showed how to use 7-zip in the other performance thread.

[savant]

spice is right, just isolating one comment reply the size is 2.59kb.
If you have 10 comments then the size is 25.9kb
gzip will help compress it, but compressing an already smaller code is even better heh :)

[SPICE]

Aha! I think, I solve this problem, but need some time for clean up and test. What I have now:
one form both for comment and reply at the bottom,
when user hit reply link he jumps to the form,
both comment and reply works perfect,
edit link works too.
But may be there is something I've lost...

By the way, I have had to modificate some code in comment.php, not big.

[kbeeveer46]

SPICE, we'd like to check it out if you would post it.

[SPICE]

we'd like to check it out if you would post it.

I've replace this

		if(strlen($_POST['comment_content']) > 0){
			$comment->content=$_POST['comment_content'];
			$cancontinue = true;
			// this is a normal new comment
		}

		if(strlen($_POST['reply_comment_content-'.$_POST['comment_parent_id']]) > 0){
			$comment->content = $_POST['reply_comment_content-'.$_POST['comment_parent_id']];
			$comment->parent=$_POST['comment_parent_id'];
			$cancontinue = true;
			// this is a reply to an existing comment
		}

to this

		if(($_POST['parent_id'])==''){
			$comment->content=$_POST['comment_content'];
			$cancontinue = true;
			// this is a normal new comment
		}

		if(($_POST['parent_id']) != ''){
			$comment->content = $_POST['comment_content'];
			$comment->parent=$_POST['parent_id'];
			$cancontinue = true;
			// this is a reply to an existing comment
		}

in story.php

replace

<a href = "javascript://" onClick="var replydisplay=document.getElementById('reply-{$comment_id}').style.display ? '' : 'none'; document.getElementById('reply-{$comment_id}').style.display = replydisplay;">Reply</a>

to

<a href = "#comment" onClick="document.getElementById('justcomment').style.visibility = 'visible'; document.getElementById('label').innerText = 'Reply for {$user_username}'; document.getElementById('parent_id').innerText = '{$comment_id}';">Reply</a>

in comment_show.tpl

and finaly add some code to comment_form.tpl

<fieldset><legend>{#PLIGG_Visual_Comment_Send#}</legend>

replace with

<fieldset><legend id="label" name="comment">{#PLIGG_Visual_Comment_Send#}</legend>

and

<input type="hidden" name="parent_id" id="parent_id" value="">

after

<input type="hidden" name="user_id" value="{$user_id}" />

Of cause, delete hidden layer in comment_show.tpl from

<div id="reply-{$comment_id}" style="display:none;">

to

  					</fieldset>
  				</form>
  			</div>
  		</div>

Hopes I wrote all clearly, 'cause do a lot of template changes before :))). Backup files before!

[kbeeveer46]

I went ahead and tested this code. It seems to get rid of threaded comments though. So you're either looking for speed without threaded comments or threaded comments.