some thoughts on RSS import feature

[newskicks]

Hi.
from last couple of days i was playing with this new feature.here are some of my obsevations:-
1)current code is buggy(i taken one from svn).it only imports one feed no matter how many you configured.the bug is in a return statment :-
$sql = "Update `feeds` set `feed_last_check` = FROM_UNIXTIME(" . (time()-300) . ") where `feed_id` = $feed->feed_id;";
//echo $sql;
return $db->query($sql);

it is called in a internal for loop so it process the first feeds data and exists from the function or php code without processing next feed.
to correct it cut and paste this code before the following function declration:-

function get_val($item, $theField)

2)if we import some feeds like google news etc then they messup the pligg sites.the reson is there rss feeds contains HTML formatting element like <table> or <a href> etc etc.
so we need a way to filter out html elements from feeds.

3)it would be nice if we can give user a option to select the feed which he want to import from list.in currentl situation there is no option.(not sure if it will be there in final release)

i will keep you updated.

[jitgos]

Thanks newskicks,

I've already posted as a bug the need to strip html from the feeds. I'm sure ash will take a look at this and see what he can do.

Jitgos

[newskicks]

just a small thing i did in this script.
i wanted that whenever i import a feed each feed item get random votes between 0-20. so i searched for this line in magpietest.php :- require_once(mnminclude.'votes.php');
and added follwoing bellow it:-
$feed->feed_votes=rand(0,15);

works fine for me

[jitgos]

haha tricky .... but cool

Jitgos

[chuckroast]

newskicks

That is a great idea.
I am asuming that some stories would go directly to published and some to the queued?

[AshDigg]

Originally Posted by newskicks

just a small thing i did in this script.
i wanted that whenever i import a feed each feed item get random votes between 0-20. so i searched for this line in magpietest.php :- require_once(mnminclude.'votes.php');
and added follwoing bellow it:-
$feed->feed_votes=rand(0,15);

works fine for me

This is a feature that I am planning to add.

[newskicks]

Originally Posted by chuckroast

newskicks

That is a great idea.
I am asuming that some stories would go directly to published and some to the queued?

nope for that you have to modify another variable:-
search following :-
$linkres->status=$feed->feed_status;
and replace it with:-
$linkres->status="published";

you can even write some more code so that some stories goes in to published and some in qued

[jitgos]

Originally Posted by chuckroast

newskicks

That is a great idea.
I am asuming that some stories would go directly to published and some to the queued?

If you had the votes set to random 0-20 and then set your votes to be published setting at something like 10 then some would be published and some queued. Seems like a quick way to do this.

Jitgos

[boyles]

Just playing devils advocate for a moment.

Doesn't this make it very easy for some lazy person to setup a new pligg site with instant (duplicate) content by importing other pligg-sites rss feeds.

Of course they wouldn't have an instant community, but would affect your pagerank etc, because of duplicate content.

I realise that this can't be prevented, but perhaps it should be discouraged by adding some Terms and Conditions ?

[AshDigg]

Originally Posted by jitgos

If you had the votes set to random 0-20 and then set your votes to be published setting at something like 10 then some would be published and some queued. Seems like a quick way to do this.

Jitgos

It didn't work that way, but I fixed some code so it will now.