[ablaye]

I found a corner case bug with category URLs being incorrectly formed in story.php.
It involves when you are using Friendly URL's for categories.
Let's say you have a category called 'Arts & Sciences". When you created this category and the makeCategoryFriendly function was applied to it, you end up with 'Arts_Sciences' (the '&' gets changed to '_') which is fine so far.

However, if story.php, the code tries to use $globals['category_url'] (which has been already sanitized) and apply to it the makeCategoryFriendly function again.

$navwhere['link1'] = getmyurl('maincategory', makeCategoryFriendly($globals['category_url']));

This is wrong, because the $globals['category_url'] variable which contains now 'Arts_Sciences' now gets changed to 'ArtsSciences' (the '_' gets changed to ''), so you end up with a broken URL (since the correct URL for the category should have 'Arts_Sciences').

Again, this is a corner case. You are applying makeCategoryFriendly to an already sanitized version of the category name and messing it up.
I fixed this by removing the makeCategoryFriendly function:

$navwhere['link1'] = getmyurl('maincategory', $globals['category_url']);

Please NOTE that I am using Friendly URL's for categories, so this code fixes my problem. However, I don't know how this will work if someone isn't using this method.
So be careful with this fix as I am not aware of the implication with NOT using Friendly URL's for categories.

[AshDigg]

Thanks for catching this. I'll update the Pligg SVN code.