[gr8rcake]

Hello,

I have got pligg to work OK, but there are a lot of errors in the /var/log/httpd/error_log file. Things like constants being redefined, indexes being undefined etc.

Could lead to some stability issues. Also could fill up the /var partition on busy sites.

The main offenders seem to be html1.php, utils.php and index.php


Loading the home page

#
[client 67.169.x.x] PHP Notice: Constant PLIGG_Visual_Search_SearchOf already defined in /home/www/pligg/libs/options.php on line 21
[client 67.169.x.x] PHP Notice: Constant PLIGG_Visual_Search_SearchOf already defined in /home/www/pligg/libs/options.php on line 22
[client 67.169.x.x] PHP Notice: Constant PLIGG_Visual_User_Navbar already defined in /home/www/pligg/libs/options.php on line 148
[client 67.169.x.x] PHP Notice: Constant PLIGG_Visual_User_Navbar already defined in /home/www/pligg/libs/options.php on line 149
[client 67.169.x.x] PHP Notice: Constant PLIGG_Visual_User_Navbar already defined in /home/www/pligg/libs/options.php on line 150
[client 67.169.x.x] PHP Notice: Undefined index: page in /home/www/pligg/libs/utils.php on line 69
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/libs/utils.php on line 69
[client 67.169.x.x] PHP Notice: Undefined index: id in /home/www/pligg/index.php on line 38
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/index.php on line 39
[client 67.169.x.x] PHP Notice: Undefined index: search in /home/www/pligg/index.php on line 40
[client 67.169.x.x] PHP Notice: Undefined index: search in /home/www/pligg/libs/html1.php on line 27
[client 67.169.x.x] PHP Notice: Undefined property: user_level in /home/www/pligg/libs/utils.php on line 133
[client 67.169.x.x] PHP Notice: Undefined property: user_level in /home/www/pligg/libs/utils.php on line 133
[client 67.169.x.x] PHP Notice: Undefined variable: new_array in /home/www/pligg/libs/db.php on line 311
[client 67.169.x.x] PHP Notice: Undefined index: page in /home/www/pligg/libs/utils.php on line 69
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/libs/html1.php on line 54
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/libs/html1.php on line 54
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/libs/html1.php on line 54
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/libs/html1.php on line 54
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/libs/html1.php on line 54
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/libs/html1.php on line 54
#

Clicking the "register" button

#
[client 67.169.x.x] PHP Notice: Constant PLIGG_Visual_Search_SearchOf already defined in /home/www/pligg/libs/options.php on line 21, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Constant PLIGG_Visual_Search_SearchOf already defined in /home/www/pligg/libs/options.php on line 22, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Constant PLIGG_Visual_User_Navbar already defined in /home/www/pligg/libs/options.php on line 148, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Constant PLIGG_Visual_User_Navbar already defined in /home/www/pligg/libs/options.php on line 149, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Constant PLIGG_Visual_User_Navbar already defined in /home/www/pligg/libs/options.php on line 150, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Undefined index: id in /home/www/pligg/register.php on line 15, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/register.php on line 16, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Undefined index: search in /home/www/pligg/register.php on line 17, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Undefined index: search in /home/www/pligg/libs/html1.php on line 27, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Undefined property: user_level in /home/www/pligg/libs/utils.php on line 133, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Undefined property: user_level in /home/www/pligg/libs/utils.php on line 133, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/libs/html1.php on line 54, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/libs/html1.php on line 54, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/libs/html1.php on line 54, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/libs/html1.php on line 54, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/libs/html1.php on line 54, referer: http://www.foo.org/
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/libs/html1.php on line 54, referer: http://www.foo.org/
#

After submitting a new user, before getting the validation

#
[client 67.169.x.x] PHP Notice: Constant PLIGG_Visual_Search_SearchOf already defined in /home/www/pligg/libs/options.php on line 21, referer: http://www.foo.org/register
[client 67.169.x.x] PHP Notice: Constant PLIGG_Visual_Search_SearchOf already defined in /home/www/pligg/libs/options.php on line 22, referer: http://www.foo.org/register
[client 67.169.x.x] PHP Notice: Constant PLIGG_Visual_User_Navbar already defined in /home/www/pligg/libs/options.php on line 148, referer: http://www.foo.org/register
[client 67.169.x.x] PHP Notice: Constant PLIGG_Visual_User_Navbar already defined in /home/www/pligg/libs/options.php on line 149, referer: http://www.foo.org/register
[client 67.169.x.x] PHP Notice: Constant PLIGG_Visual_User_Navbar already defined in /home/www/pligg/libs/options.php on line 150, referer: http://www.foo.org/register
[client 67.169.x.x] PHP Notice: Undefined index: id in /home/www/pligg/register.php on line 15, referer: http://www.foo.org/register
[client 67.169.x.x] PHP Notice: Undefined index: category in /home/www/pligg/register.php on line 16, referer: http://www.foo.org/register
[client 67.169.x.x] PHP Notice: Undefined index: search in /home/www/pligg/register.php on line 17, referer: http://www.foo.org/register
[client 67.169.x.x] PHP Notice: Undefined index: search in /home/www/pligg/libs/html1.php on line 27, referer: http://www.foo.org/register
[client 67.169.x.x] PHP Notice: Undefined property: user_level in /home/www/pligg/libs/utils.php on line 133, referer: http://www.foo.org/register
[client 67.169.x.x] PHP Notice: Undefined property: user_level in /home/www/pligg/libs/utils.php on line 133, referer: http://www.foo.org/register
[client 67.169.x.x] PHP Notice: Use of undefined constant HTTP_USER_AGENT - assumed 'HTTP_USER_AGENT' in /home/www/pligg/libs/ts.php on line 12, referer: http://www.foo.org/register
[client 67.169.x.x] PHP Notice: Undefined variable: sitekey in /home/www/pligg/libs/ts.php on line 12, referer: http://www.foo.org/register
[client 67.169.x.x] PHP Notice: Undefined variable: string in /home/www/pligg/libs/ts.php on line 21, referer: http://www.foo.org/register
#

[clancey]

I have been cleaning these up on my personal install of pligg. The problem is created when the program calls global variables and array variables without checking to see if they exist and/or if they have not having been filled with default values. These problems are all over the source. Hopefully some have been corrected in beta6

The ones I have tracked down would not cause problems with the running of the code. The code behaves correctly when the condition it is testing or referring to does not exist.

During beta testing and debugging, you want PHP to issue all warnings, etc, to help track down bugs. And they need to be tracked down. Not doing so, results in logs which are plugged with stupid warnings, making it harder to find those that relate to real problems.

After two weeks my error log is 5.16 megs and my access log 1.46 megs. Until these are all tracked down, the only thing you can do is zero out your error log from time to time. Mine generates so many errors, I just run tail to see if the latest ones are real -- or more references to non-existent variables.

I would love to run through beta6 and try to track down as much of this as I can -- but my weekend is very full and I will not have any time until sometime next week.

[clancey]

Further to my initial thread. You can also limit the errors reported by PHP in either your php.ini file or by adding something to the config.php file, which is called fro all the php modules in pligg. Some examples from php.net are:

<?php

// Turn off all error reporting
error_reporting(0);

// Report simple running errors
error_reporting(E_ERROR | E_WARNING | E_PARSE);

// Reporting E_NOTICE can be good too (to report uninitialized
// variables or catch variable name misspellings ...)
error_reporting(E_ERROR | E_WARNING | E_PARSE | E_NOTICE);

// Report all errors except E_NOTICE
// This is the default value set in php.ini
error_reporting(E_ALL ^ E_NOTICE);

// Report all PHP errors (bitwise 63 may be used in PHP 3)
error_reporting(E_ALL);

// Same as error_reporting(E_ALL);
ini_set('error_reporting', E_ALL);

?>

[AshDigg]

Almost done with tags.... then I'll attack these errors.