[kossmoss]

Link class can convert link title got from URL only if source HTML code has '<meta http-equiv="Content-Type" ....' tag. Many pages has no encoding specified in their HTML code, but specified in their http headers. When I add link to such a page, I see something like this:


To fix this, add some code to libs/link.php:
class PliggHTTPRequest:

//new variable for content-type header
var $content_type;	//content-type

and these lines in function DownloadToString() to save this header (I inserted them before redirection section)

			if(isset($headers['content-type']))
				$this->content_type = $headers['content-type'];

after that add following code to class Link, function get():

		if(preg_match('/charset=([a-zA-Z0-9-_]+)/i', $this->html, $matches)) {
			//no need to change code here - kossmoss
			.....
			.....
		}
		else if(preg_match('/charset=([a-zA-Z0-9-_]+)/i', $r->content_type, $matches)) {
			$this->encoding=trim($matches[1]);
			//you need iconv to encode to utf-8
			if(function_exists("iconv"))
			{
				if(strcasecmp($this->encoding, 'utf-8') != 0) {
					//convert the html code into utf-8 whatever encoding it is using
					$this->html=iconv($this->encoding, 'UTF-8//IGNORE', $this->html);
				}
			}
		}

Thus, we can get properly converted title in any case. Probably, another thing still need to add - support of mb_convert_string() method, if iconv() doesn't supported by PHP instance.

[semofir]

Originally Posted by kossmoss

Link class can convert link title got from URL only if source HTML code has '<meta http-equiv="Content-Type" ....' tag. Many pages has no encoding specified in their HTML code, but specified in their http headers. When I add link to such a page, I see something like this:


To fix this, add some code to libs/link.php:
class PliggHTTPRequest:

//new variable for content-type header
var $content_type;	//content-type

and these lines in function DownloadToString() to save this header (I inserted them before redirection section)

			if(isset($headers['content-type']))
				$this->content_type = $headers['content-type'];

after that add following code to class Link, function get():

		if(preg_match('/charset=([a-zA-Z0-9-_]+)/i', $this->html, $matches)) {
			//no need to change code here - kossmoss
			.....
			.....
		}
		else if(preg_match('/charset=([a-zA-Z0-9-_]+)/i', $r->content_type, $matches)) {
			$this->encoding=trim($matches[1]);
			//you need iconv to encode to utf-8
			if(function_exists("iconv"))
			{
				if(strcasecmp($this->encoding, 'utf-8') != 0) {
					//convert the html code into utf-8 whatever encoding it is using
					$this->html=iconv($this->encoding, 'UTF-8//IGNORE', $this->html);
				}
			}
		}

Thus, we can get properly converted title in any case. Probably, another thing still need to add - support of mb_convert_string() method, if iconv() doesn't supported by PHP instance.

Kossmoss,
Thank you for your mod, but still cant work this out.
I have got the same issue problem but when i add to "class Link, function get()" i receive
-----------Parse error: syntax error, unexpected T_IF, expecting '&' or T_VARIABLE in /home/bubahuba/public_html/izberi-kupi.com/libs/link.php on line 62-----------
I will hope for your repply!

[semofir]

else if(preg_match('/charset=([a-zA-Z0-9-_]+)/i', $r->content_type, $matches)) {
$this->encoding=trim($matches[1]);
//you need iconv to encode to utf-8
if(function_exists("iconv"))
{
if(strcasecmp($this->encoding, 'utf-8') != 0) {
//convert the html code into utf-8 whatever encoding it is using
$this->html=iconv($this->encoding, 'UTF-8//IGNORE', $this->html);
}

IT is not accepting me "else" this is the problem I think.

[kossmoss]

Your problem seems to be caused by incorrect PHP syntax (I wrote my code for an older Pligg version, so it probably needs some modification for Pligg v1).
What part of this code you have on line 62?

[semofir]

I manage it this way: I erased on the very end

//print_r($headers);
if (extension_loaded('iconv') && preg_match('/charset=(.+)$/',$headers['content-type'],$m))
$body = iconv($m[1],"UTF-8",$body);

and it is now okey. Thank you.

I am using pligg 1.0.0 and that's why, may be. On line 62 I have got

function get($url) {
$url=trim($url);

Thanks for your attention