 |
| | Thread Tools | Display Modes |
11-08-2006, 12:14 AM
| |||
| |||
|
On the login screen after clicking on the button to send a forgotten password confirmation code, the system messages like PLIGG_PassEmail_SendSuccess that should be displayed in the second step of the forgotten password process are appearing at the very top of the page and breaking the layout. When I viewed the html source i found that the messages were actually at the very start of the html document ... above the <head> and even the DOC declaration.  |
|
11-08-2006, 12:22 AM
| |||
| |||
|
I believe all the "forgotten email" notifications were overlooked when we went and moved the errors into better locations. I, too, don't think they should be at the top of the page.
|
|
11-08-2006, 09:50 AM
| |||
| |||
|
Pligg's forgotten password system is already unconventional so it's important that the messages are being displayed in the right spot. On most sites users recieve an email with a link that contains the confirmation code. The user just clicks on the link to be taken back to the forgotten password process. On Pligg the user has to copy and paste the confirmation code from the email back into the form. But they can't close their browser window between requesting the code and receiving the email or they will have no way to get back to the form without requesting a new confirmation code. I am modifying the messages on this page to tell users not to close their browser window while checking their email. These messages neeed to be front and center or the user willl probably miss them. Any suggestions on how i can put these messages in the center of the page right above the form? |
|
11-08-2006, 10:07 AM
| ||||
| ||||
| Quote:
|
|
11-08-2006, 11:36 AM
| |||
| |||
|
i've found out where to add the link to the body of the email (login.php line 59 - $body = ...) but i can't get the link to display the second step of the forgotten password sequence. I've tried using: Code: http://mydomain.com/pligg/login.php?processlogin=4 Any suggestions? I am going to try modifying login.php to use $_GET instead but i don't know if this introduces any security problems or any other headaches. Last edited by revolver; 11-08-2006 at 11:44 AM. |
|
11-08-2006, 12:25 PM
| |||
| |||
|
Ok i got it to work: Here's what i had to change in login.php ... ---------------------------- Line 30: if(isset($_POST["processlogin"]) || isset($_GET["processlogin"])){ Line 59: $body = PLIGG_PassEmail_Body . $my_base_url . $my_pligg_base . '/login.php?processlogin=4&username=' . $username . '&confirmationcode=' . $saltedlogin; Line 99: if($_GET["processlogin"] == 4) { Line 100: $username = trim($_GET['username']); Line 105: $confirmationcode = $_GET["confirmationcode"]; Lines 76 to 82: Comment these lines out. They display the Forgotten Password Step 2 template containing the confirmation code form which is no longer necessary because the code is now included in the link in the email. ---------------------------- i'd like to know whether switching to $_GET from $_POST introduces any security issues. |
|
11-08-2006, 12:28 PM
| |||
| |||
|
.... We still need to fix the problem with the messages displaying at the top of the page because they are breaking the layout and pushing down the header and need to be in the center where users can see them. Unfortunately i really don't have a clue how to get them in the right spot. |
|
11-08-2006, 01:08 PM
| |||
| |||
|
Thanks revolver. If I had some time I would try to work on the notification message but I have to get ready for a meeting. This link might help you out. It's when ash moved the "data saved" message when you saved your profile. It also used to be above the header. Check out profile.php and profile_center.tpl http://pligg.svn.sourceforge.net/vie...v&revision=173 |
|
11-09-2006, 11:14 AM
| |||
| |||
|
Hey kbeever46 ... i've taken a look at it and i think the issue may come down the current page using echo to display the messages rather than storing the messages in a variable and waiting to display them. But i have very little understanding of smarty and don't feel comfortable that i am going to find the best solution to this. Do you or AshDigg have the time to be able to take a stab at it?
|
|
11-11-2006, 03:34 PM
| |||
| |||
|
I went ahead and added this to Pligg http://pligg.svn.sourceforge.net/vie...v&revision=272 The next step is changing the placement of those notifications. |
|
| Thread Tools | |
| Display Modes | |
| |
Similar Threads | ||||
| Thread | Thread Starter | Forum | Replies | Last Post |
| Forgotten Password is working? | eldelao | Questions and Comments | 2 | 02-28-2010 01:16 PM |
| email user forgotten password and username | momanity | Questions and Comments | 2 | 07-11-2008 07:47 PM |
| Forgotten password - "From" email field - where can this be changed? | TJ3 | Questions and Comments | 2 | 03-31-2007 03:17 PM |
| Admin_index forgotten password form doesn't point to subfolder | jiolasa | Questions and Comments | 0 | 04-18-2006 02:03 AM |
Linear Mode
