Messaging Usability

[MobileFreak]

While sending a private message, if the user does not enter the subject and the message and presses the send button, a message is displayed "there was an error. error number -" and the only way the user can leave that frame is by pressing the browser back button.

I made a minute modification to indicate the failure of sending and displaying the cross button. the changes where :
1. In messaging_main.php, in the "if ($msg_result != 0){" condition, put the following code -

if(messaging_fade_lightbox){
$main_smarty->assign('js_close', "Effect.Fade('overlay');Effect.Fade('view_message' , {afterFinish: function(){document.getElementById('view_message') .innerHTML='loading...';}});");
}else{
$main_smarty->assign('js_close', "document.getElementById('overlay').style.display = 'none';document.getElementById('view_message').sty le.display = 'none';document.getElementById('view_message').innerHTML='loading...';");
}
//echo "there was an error. error number " . $msg_result;
$main_smarty->display(messaging_tpl_path . 'small_send_fail.tpl');

2. create small_send_fail.tpl similar to small_send_success.tpl in templates folder.

[TrailofDead]

You will get an error message if either the message subject or message body are empty. I think a better option is to alert the user that they must enter a subject and message body. Therefore, edit your ./modules/messaging/templates/messaging_lightbox.tpl file and modify the messaging_ajax_send() function and add the following after the variables declaration:

			if (msg_subj == "") 
			{
				alert ("You must enter a subject");
				return;
			}
			if (msg_body == "") 
			{
				alert ("You're message is blank");
				return;
			}

[Geoserv]

I just realized that nothing happens when I try to message someone.

I click on "send (username) a message", but nothing happens. heres the link associated with it:

http://www.newsdots.com/user.php?log...e#view_message

Geoserv.

[Simon]

Do you get any javascript errors when clicking? I went to the link above, and there are a couple or errors associated with lightbox.js

[Geoserv]

I have lightbox errors throughout, same 2 errors I think according to FF error log. So far the messaging is the only thing not working that I know of.

Geoserv.

[Simon]

Has it never worked, or did it stop working when you installed something in particular?

[Geoserv]

I'm not sure, I have never used it before. To my kknowledge everything was working at one time.

Here are the 2 errors I get:

Error: Effect is not defined
Source File: http://www.newsdots.com/templates/di.../js/misc.js.gz
Line: 71

Effect.DropIn = function(element) {

Error: Event.observe is not a function
Source File: http://www.newsdots.com/modules/lightbox/js/lightbox.js
Line: 60

Event.observe(window, 'load', initialize, false);

I'm not sure if they have anything to do with this or not.

Geoserv

[Geoserv]

I have Googled this two things, but wasn't aboe to come up with anything that would solve the errors.

Geoserv

[Simon]

It could be because your lightbox.js file is loading before the prototype.js files - you might want to try switching them around. Something like:

prototype.js (plus all the files that come with it)
jquery.js
thickbox.js
lightbox.js
misc.js.gz

Just a guess, but sometimes loading order can break scripts.

[Geoserv]

I can't find the file that changes the order, I was looking at it earlier, it isn't pligg.tpl, theres another one.

Geoserv